sandbox allowed domains#712
Open
kcoopermiller wants to merge 2 commits into
Open
Conversation
kcoopermiller
requested review from
JannikSt,
JohannesHa,
burnpiro,
d42me and
willccbb
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes sandbox network egress configuration at create time; misconfigured domain lists could block required outbound access, though rules are validated client-side and in the SDK.
Overview
Adds egress domain controls for container sandboxes via
allowed_domainsandblocked_domainson the SDKSandbox/CreateSandboxRequestmodels (API aliasesallowedDomains/blockedDomains).allowed_domainsis an egress allowlist for restricted sandboxes: it only applies whennetwork_accessis false and is not supported on VM sandboxes.blocked_domainsis an egress blocklist for open sandboxes: it requiresnetwork_accesstrue and is also VM-incompatible. Pydantic validators enforce these rules on create.The
prime sandbox createcommand gains repeatable--allowed-domainand--blocked-domain(wildcards like*.example.comdocumented in help), with matching CLI checks before the API call.prime sandbox getand the create confirmation summary show the lists when present.Reviewed by Cursor Bugbot for commit 21f84fd. Bugbot is set up for automated code reviews on this repo. Configure here.